feat(ratelimiter): expose GET /info endpoint - #591

src/invocation-plane-services/ratelimiter/cmd/info_test.go (1)

44-50: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Verify metadata from the stamped binary.

These assertions accept "unknown" values. The tests can pass if the go_binary linker definitions are removed or use incorrect keys. Add a stamped-binary test that verifies the injected service, version, and commit values, or confirm that the repository’s go_test rule can apply equivalent x_defs.

As per coding guidelines, “Code changes must include tests.” Based on learnings, use the repository-native test runner for build and test rules.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/invocation-plane-services/ratelimiter/cmd/info_test.go` around lines 44 -
50, Strengthen the metadata test around the stamped binary response so it
verifies the expected injected service, version, and commit values rather than
merely checking non-empty fields or allowing "unknown". Use the
repository-native build/test runner and either add a stamped-binary test or
configure the go_test rule with equivalent x_defs, ensuring the assertions
detect missing or incorrect linker keys.

Sources: Coding guidelines, Learnings

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

src/invocation-plane-services/ratelimiter/cmd/info_test.go (2)

58-66: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Expand the non-GET method coverage.

The table checks only POST, PUT, and DELETE. Add standard methods such as HEAD, PATCH, and OPTIONS to detect method-specific regressions. The /info contract requires 405 Method Not Allowed, Allow: GET, and an empty body for non-GET requests.

As per PR objectives, non-GET requests to /info must return 405 Method Not Allowed with Allow: GET.

Suggested test expansion

-		for _, method := range []string{http.MethodPost, http.MethodPut, http.MethodDelete} {
+		for _, method := range []string{
+			http.MethodHead,
+			http.MethodPost,
+			http.MethodPut,
+			http.MethodPatch,
+			http.MethodDelete,
+			http.MethodOptions,
+		} {

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/invocation-plane-services/ratelimiter/cmd/info_test.go` around lines 58 -
66, Expand the non-GET method table in the `/info` handler test to include
`HEAD`, `PATCH`, and `OPTIONS` alongside the existing methods. Preserve
assertions that every listed method returns `405 Method Not Allowed`, `Allow:
GET`, and an empty response body.

---

44-50: 🗄️ Data Integrity & Integration | 🔵 Trivial | 🏗️ Heavy lift

Add a Bazel test for build-time metadata.

x_defs is configured only on cmd, while cmd_test embeds cmd_lib. The current assertions therefore accept "unknown" and do not validate the service name, version, or full commit SHA. Add an integration test with known service, version, and full commit values, and retain this unit test for fallback behavior.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/invocation-plane-services/ratelimiter/cmd/info_test.go` around lines 44 -
50, Add a Bazel integration test for the ratelimiter info command that supplies
known build-time x_defs values and asserts the exact service name, version, and
full commit SHA in the response. Keep the existing test in the info command test
flow focused on fallback behavior, including its non-empty assertions for
unresolved metadata.